ruby - Rails response.should be_success is never true -

-

i following michael hartl's excellent tutorial on ruby on rails. i'm stuck trying understand way actiondispatch::response works. derives exercise 9 of chapter 9 (rails version 3.2.3).

in particular we're asked make sure admin user unable user#destroy himself. have idea how that, since i'm trying follow tdd methodology, i'm first writing tests.

this relevant snippet in test:

describe "authorization"     describe "as non-admin user"         let(:admin) {factorygirl.create(:admin)}         let(:non_admin) {factorygirl.create(:user)}          before{valid_signin non_admin}          describe "submitting delete request users#destroy action"             before                 delete user_path(admin)                 #puts response.message                 puts response.succes?             end             specify{ response.should redirect_to(root_path) }             specify{ response.should_not be_success }         end     end     #exercise 9.6-9 prevent admin destroying himself     describe "as admin user"         let(:admin){factorygirl.create(:admin)}         let(:non_admin){factorygirl.create(:user)}          before              valid_signin admin         end         "should able delete user"             expect { delete user_path(non_admin) }.to change(user, :count).by(-1)         end          describe "can destroy others"             before                  puts admin.admin?                 delete user_path(non_admin)                 puts response.success?             end             #specify{response.should be_success}             specify{response.should_not be_redirect}         end           describe "cannot destroy himself"             before                 delete user_path(admin)                 puts response.success?             end             #specify{response.should_not be_success}             specify{response.should be_redirect}         end      end  . . . end

all tests pass except "can destroy others" test.

however, if puts response.success? after every delete request, false, none of requests "succeed".

manually interacting webapp , deleting users works fine, assume response.success not mean detroy(or whatever request matter) not successful, else. read has difference between http responses 200/302/400, i'm not totally sure.

for record, user#destroy:

def destroy     user.find(params[:id]).destroy     flash[:success]="user destroyed."     redirect_to users_path end

any light on this? thanks!

edit

this factory:

factorygirl.define     factory :user         sequence(:name){ |n| "person #{n}" }         sequence(:email){ |n| "person_#{n}@example.com"}         password "foobar"         password_confirmation "foobar"          factory :admin             admin true         end     end  end

edit 2 suggested @peter alfvin, changed lines

let(:user){factorygirl.create(:user)}

to

let(:admin){factorygirl.create(:admin)}

and user admin in general. added puts admin.admin? before delete request. still not working!

edit 3

changing test "can destroy others" as:

describe "can destroy others"   before      puts admin.admin?     delete user_path(non_admin)     puts response.success?   end    #specify{response.should be_success}   specify{response.should_not be_redirect}  end

does not seem either.

for "admin" case, you're still creating , logging in "regular" user instead of admin user, why can't destroy else.


Comments

Post a Comment

Popular posts from this blog

c# - How Configure Devart dotConnect for SQLite Code First? -

-
can configure following sample code ? when run following code, error : no entity framework provider found ado.net provider invariant name 'devart.data.sqlite' setting in machine.config <system.data> <dbproviderfactories> <add name="dotconnect sqlite" invariant="devart.data.sqlite" description="devart dotconnect sqlite" type="devart.data.sqlite.sqliteproviderfactory, devart.data.sqlite, version=4.6.287.0, culture=neutral, publickeytoken=09af7300eec23701" /> </dbproviderfactories> </system.data> after add below block code in app.config <?xml version="1.0"?> <configuration>   <configsections> <!-- more information on entity framework configuration, visit http://go.microsoft.com/fwlink/?linkid=237468 --> <section name="entityframework" type="system.data.entity.internal.configfile.entityframeworksection, entit...
Read more

java - Copying object fields -

-
what best way of copying classes when need have 2 independent variables? have simple class: public class myclass { boolean = false; string b= "not empty"; } do need make method : assign(myclass data ) { a= data.a; b= data.b; } is there automatic method copy (duplicate) objects in java? do need make method : pretty close. instead of making method, should make constructor. such constructors called copy constructor , , create them this: myclass(myclass data) { = data.a; b = data.b; } and create copy of instance, use constructor this: myclass obj1 = new myclass(); myclass obj2 = new myclass(obj1); copy constructor can tedious : using copy constructor create deep-copy can tedious, when class has mutable fields. in case, assignment create copy of reference, , not object itself. have create copy of fields (if want deep copy). can go recursive. a better way create deep copy serialize , deserialize object. why not use clone()? ...
Read more

c++ - Clear the memory after returning a vector in a function -

-
i have function processes , stores lot of data in , returns results vector of class. amount of data stored in function tremendous , want clear storage memory of function after finished job. necessary (does function automatically clear memory) or should clear memory function? update: vector<customers> process(char* const *filename, vector<int> id) { vector<customers> list_of_customers; (perform actions) return list_of_customers; } variables defined locally within function automatically released @ end of function scope. destructors objects called, should free memory allocated objects (if objects coded correctly). example of such object std::vector . anything you've allocated new must have corresponding delete release storage. try avoid doing own allocation , use raii instead, i.e. containers or smart pointers.
Read more