loops - how to make this php code shorter? -

-

i have following php code works long , cumbersome reading...

// row  if ($taktarticle[0]['t1position3'] > 3 , $taktarticle[0]['t1position3'] < 7  ) {    $row = "row1";  }   if ($taktarticle[0]['t1position3'] > 7 , $taktarticle[0]['t1position3'] < 12  ) {    $row = "row2";  }   if ($taktarticle[0]['t1position3'] > 12 , $taktarticle[0]['t1position3'] < 17  ) {    $row = "row3";  }   if ($taktarticle[0]['t1position3'] > 17 , $taktarticle[0]['t1position3'] < 22  ) {    $row = "row4";  }   if ($taktarticle[0]['t1position3'] > 22 , $taktarticle[0]['t1position3'] < 27  ) {    $row = "row5";  }   // columns  if ($taktarticle[0]['t1position3'] == 3       or $taktarticle[0]['t1position3'] == 8       or $taktarticle[0]['t1position3'] == 13       or $taktarticle[0]['t1position3'] == 18       or $taktarticle[0]['t1position3'] == 23) {     $col = "col1";  }     if ($taktarticle[0]['t1position3'] == 4       or $taktarticle[0]['t1position3'] == 9       or $taktarticle[0]['t1position3'] == 14       or $taktarticle[0]['t1position3'] == 19       or $taktarticle[0]['t1position3'] == 24) {     $col = "col2";  }   if ($taktarticle[0]['t1position3'] == 5       or $taktarticle[0]['t1position3'] == 10       or $taktarticle[0]['t1position3'] == 15       or $taktarticle[0]['t1position3'] == 20       or $taktarticle[0]['t1position3'] == 25) {     $col = "col3";  }   if ($taktarticle[0]['t1position3'] == 6       or $taktarticle[0]['t1position3'] == 11       or $taktarticle[0]['t1position3'] == 16       or $taktarticle[0]['t1position3'] == 21       or $taktarticle[0]['t1position3'] == 26) {     $col = "col4";  }   if ($taktarticle[0]['t1position3'] == 7       or $taktarticle[0]['t1position3'] == 12       or $taktarticle[0]['t1position3'] == 17       or $taktarticle[0]['t1position3'] == 22       or $taktarticle[0]['t1position3'] == 27) {     $col = "col5";  }

now... have repeat ($taktarticle[0]['t1position3'] until ($taktarticle[0]['t1position11']

as understand, code become huge...anyone have idea how code can shortened?

regards, john

you can create functions clean code. there obvious patterns in code, looking patterns , generalizing patterns key requirement cleaning code. i'm sure php guru find more concise way accomplish this, basic example like:

function get_row($position) {   $row_ranges = array(     array(3, 7),     array(7, 12),     // etc   );         foreach ($row_ranges $row_index => $range) {     if ($range[0] < $position && $position < $range[1]) {        return sprtintf('row%s', $row_index + 1)     }   }  }

all row ranges kept in centralized location inside of function, , there no more repeated conditionals

function get_column($value) {   // looks starting @ 3 , have increments of 5    // 3, 8, 13, 18   // loop through , calculate these, or hardcode them in   //  use `in_array` clean multiple or statements   if (in_array($value, array(3, 8, 13, 18))) {    } }

Comments

Post a Comment

Popular posts from this blog

c# - How Configure Devart dotConnect for SQLite Code First? -

-
can configure following sample code ? when run following code, error : no entity framework provider found ado.net provider invariant name 'devart.data.sqlite' setting in machine.config <system.data> <dbproviderfactories> <add name="dotconnect sqlite" invariant="devart.data.sqlite" description="devart dotconnect sqlite" type="devart.data.sqlite.sqliteproviderfactory, devart.data.sqlite, version=4.6.287.0, culture=neutral, publickeytoken=09af7300eec23701" /> </dbproviderfactories> </system.data> after add below block code in app.config <?xml version="1.0"?> <configuration>   <configsections> <!-- more information on entity framework configuration, visit http://go.microsoft.com/fwlink/?linkid=237468 --> <section name="entityframework" type="system.data.entity.internal.configfile.entityframeworksection, entit...
Read more

java - Copying object fields -

-
what best way of copying classes when need have 2 independent variables? have simple class: public class myclass { boolean = false; string b= "not empty"; } do need make method : assign(myclass data ) { a= data.a; b= data.b; } is there automatic method copy (duplicate) objects in java? do need make method : pretty close. instead of making method, should make constructor. such constructors called copy constructor , , create them this: myclass(myclass data) { = data.a; b = data.b; } and create copy of instance, use constructor this: myclass obj1 = new myclass(); myclass obj2 = new myclass(obj1); copy constructor can tedious : using copy constructor create deep-copy can tedious, when class has mutable fields. in case, assignment create copy of reference, , not object itself. have create copy of fields (if want deep copy). can go recursive. a better way create deep copy serialize , deserialize object. why not use clone()? ...
Read more

c++ - Clear the memory after returning a vector in a function -

-
i have function processes , stores lot of data in , returns results vector of class. amount of data stored in function tremendous , want clear storage memory of function after finished job. necessary (does function automatically clear memory) or should clear memory function? update: vector<customers> process(char* const *filename, vector<int> id) { vector<customers> list_of_customers; (perform actions) return list_of_customers; } variables defined locally within function automatically released @ end of function scope. destructors objects called, should free memory allocated objects (if objects coded correctly). example of such object std::vector . anything you've allocated new must have corresponding delete release storage. try avoid doing own allocation , use raii instead, i.e. containers or smart pointers.
Read more